Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Allow multiple devpages for multiple PRs #249

Open
Prid13 opened this issue Feb 10, 2023 · 1 comment
Open

[Improvement] Allow multiple devpages for multiple PRs #249

Prid13 opened this issue Feb 10, 2023 · 1 comment

Comments

@Prid13
Copy link
Collaborator

Prid13 commented Feb 10, 2023

Problem:

  • Someone would like to test 2 different PRs on the live devpages website
  • Currently, only 1 PR can be deployed at a time
  • If a new PR is assigned the devpages label, or something is pushed to another PR with the devpages label, the previously-deployed PR gets wiped from the dev website as the new one gets auto-deployed, whether it's intended or not

Solution:

  • Somehow, multiple PRs should be deployable simulatenously and be preview-able from different links
  • Issues:
    • How to manage which PR to keep and which one to delete? Should there be an "admin" website for this? A separate PR just for this where commands are issued? Or be kept to e.g. last 2 PRs?
    • How to deploy multiple PRs to different folders?
    • How to detect last PRs with the devpages label?
@jonny-wg2
Copy link
Contributor

Mhmm unsure what the best way to solve this is..

One idea is we leverage multiple labels devpages1, devpages2, devpages3 and then we duplicate our existing setup with 3 pipelines, 3 URLs etc. This a little more infrastructure vs. building a custom frontend that does toggling etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants