Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch devel to GNOME SDK Master #980

Closed
vixalien opened this issue Aug 12, 2024 · 4 comments
Closed

Switch devel to GNOME SDK Master #980

vixalien opened this issue Aug 12, 2024 · 4 comments
Assignees

Comments

@vixalien
Copy link
Contributor

I remember we switched to 46 instead of master in #966.

However, This means we can't use ts-for-gir (in #979), because one of the dependencies requires node 20 (and hence typescript 24.08beta).

$ yarn global add @ts-for-gir/[email protected]
yarn global v1.22.22
[1/4] Resolving packages...
[2/4] Fetching packages...
error [email protected]: The engine "node" is incompatible with this module. Expected version "20 || >=22". Got "18.20.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/global for documentation about this command.

This means we should consider switching to the master. A good first point would be to list all the issues we had when we switched to master in the past.

As my internet is a bit slow, I can't really iterate on this as it requires downloading multiple runtimes and dependencies.

(cc @sonnyp @andyholmes)

@andyholmes
Copy link
Contributor

This seems like a good idea, if Sonny approves. I usually do stable/master with my stable/devel manifests as well.

@sonnyp
Copy link
Contributor

sonnyp commented Sep 20, 2024

👋

Workbench has a lot of dependencies and moving parts. From experience switching to GNOME nightly tends to break often. I try to make Workbench as easy as possible to contribute to so I'd rather stay on stable for the "main" manifest.

If needed - we could consider re.sonny.Workbench.nightly

Now that 47 is out, I'm working on upgrading which should solve your immeditate issue

Works for you?

@andyholmes
Copy link
Contributor

That makes sense to me. I guess the main focus is the demos and those have to keep working.

@sonnyp
Copy link
Contributor

sonnyp commented Sep 23, 2024

#982

@sonnyp sonnyp closed this as completed Sep 23, 2024
@sonnyp sonnyp reopened this Sep 23, 2024
@sonnyp sonnyp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants