Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work #7

Open
auisdhf878tyc807asdhfiunkm opened this issue Oct 9, 2020 · 7 comments
Open

Doesn't work #7

auisdhf878tyc807asdhfiunkm opened this issue Oct 9, 2020 · 7 comments

Comments

@auisdhf878tyc807asdhfiunkm

This doesn't seem to work anymore -- it just returns an empty array no matter what I do.

@dmahfouda
Copy link

I'm also experiencing this issue—

@wooorm
Copy link
Member

wooorm commented Oct 18, 2020

They seem to change all the time: https://github.com/words/powerthesaurus-api/issues?q=is%3Aissue+is%3Aclosed

PRs welcome to help out with a more solid solution

@wooorm
Copy link
Member

wooorm commented Apr 11, 2021

@zeke should we deprecate this perhaps? Their stuff keeps changing... 😩

@zeke
Copy link
Member

zeke commented Apr 12, 2021

@Deebah or @dmahfouda this module breaks whenever the website changes its HTML structure. The last time this happened it was a one-line change because of an updated CSS class name. Are you interested in attempting to work on a fix?

@ryanwbass
Copy link

ryanwbass commented Jun 7, 2021

@zeke Hey, I am currently looking for a good thesaurus api. Based on the website this looks pretty promising and am feeling adventurous enough to contribute to something like this. Digging through the code to understand and some debugging it looks like I would have to update:
done(null, $.selectAll('main .k3_b', tree).map(each))
as $.selectAll is returning [].
So Im assuming that '.k3_b' element had its name changed or something along those lines.

What element from the site were you guys originally selecting with that identifier?

@zeke
Copy link
Member

zeke commented Jun 8, 2021

Hi @ryanwbass thanks for jumping in. I don't remember the historical DOM structure of the site off-hand. The best way for you to proceed would be to open the PowerThesaurus website in your browser, do a search, then see the selectors in the browser's web inspector. From there you can extrapolate and figure out what selectors would need to be changed here in this package. Hope that helps.

@adnanshahri
Copy link

@zeke
Hi, is the issue still persistent?

@ryanwbass
Have you had the chance to work on this, or did you find a better API than Power Thesaurus?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants