-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't work #7
Comments
I'm also experiencing this issue— |
They seem to change all the time: https://github.com/words/powerthesaurus-api/issues?q=is%3Aissue+is%3Aclosed PRs welcome to help out with a more solid solution |
@zeke should we deprecate this perhaps? Their stuff keeps changing... 😩 |
@Deebah or @dmahfouda this module breaks whenever the website changes its HTML structure. The last time this happened it was a one-line change because of an updated CSS class name. Are you interested in attempting to work on a fix? |
@zeke Hey, I am currently looking for a good thesaurus api. Based on the website this looks pretty promising and am feeling adventurous enough to contribute to something like this. Digging through the code to understand and some debugging it looks like I would have to update: What element from the site were you guys originally selecting with that identifier? |
Hi @ryanwbass thanks for jumping in. I don't remember the historical DOM structure of the site off-hand. The best way for you to proceed would be to open the PowerThesaurus website in your browser, do a search, then see the selectors in the browser's web inspector. From there you can extrapolate and figure out what selectors would need to be changed here in this package. Hope that helps. |
@zeke @ryanwbass |
This doesn't seem to work anymore -- it just returns an empty array no matter what I do.
The text was updated successfully, but these errors were encountered: