Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#479 Translating tutorial to traditional Chinese #592

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

helenwu95
Copy link
Contributor

Context

The translation of traditional Chinese

Verification

Need another person to check if there is any content that hasn't translated into traditional Chinese before line 323.

@amyjko
Copy link
Collaborator

amyjko commented Nov 1, 2024

Hi @helenwu95! Can you clarify what you mean above, about verifying content before line 323? You can see the file and it's contents in main. Is there some reason you can't know?

@helenwu95
Copy link
Contributor Author

Hi @helenwu95! Can you clarify what you mean above, about verifying content before line 323? You can see the file and it's contents in main. Is there some reason you can't know?

Hi! @amyjko Just to clarify, my current progress on the Traditional Chinese translation is up to line 323, and I’m hoping someone can check that I’ve translated every tutorial up to that point, in case I miss something in my last check. Also, I apologize for misusing the hash earlier.

@amyjko
Copy link
Collaborator

amyjko commented Nov 1, 2024

I think I'm still unsure what you mean. Are you asking someone else who can code review your traditional Chinese translations, to make sure they are good, or that you didn't miss any translations between line 1-323? (You can check the letter easily, by just looking for English in the lines, which is why I'm confused).

@helenwu95
Copy link
Contributor Author

What I mean is that I might need someone to check if I've missed any translations before line 323. In Visual Studio, while I only need to translate the dialogue, the character names and functions, and UI settings are in English and often mixed in with the dialogue, which makes it easy to overlook something. Although I've checked everything twice before submitting, it would be helpful to have someone else review it before merging into the main branch. I will also do a comprehensive check of the translated sections in the end of this quarter, so everything should be fine.

@helenwu95
Copy link
Contributor Author

And I just found that there are some parts I didn't translate in Chapter 1, which are the "miss in first chapter (1)." I hope there won’t be any more oversights like that.

@amyjko
Copy link
Collaborator

amyjko commented Nov 2, 2024

Thanks for the clarification. When I look at lines 1-323, the main content that's not translated is code. It's still using all English names, but should be using Chinese names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants