Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line shape #171

Open
amyjko opened this issue Sep 15, 2023 · 6 comments · May be fixed by #403
Open

Line shape #171

amyjko opened this issue Sep 15, 2023 · 6 comments · May be fixed by #403
Assignees
Labels
enhancement New or improved feature output Anything related to program output starter A good issue for new contributors

Comments

@amyjko
Copy link
Collaborator

amyjko commented Sep 15, 2023

What's the problem?

The only kind of barrier supported at the moment is a non-rotated rectangle.

What's the idea?

Let's add support for a line between two points.

Who benefits?

Anyone trying to create a barrier that is sloped.

Design ideas

  • A type like Line(x1•# y1•# x2•# y2•# color•Color|ø)
  • Rendered as a line in HTML in StageView
  • Added in Physics.ts as a rotated rectangle
@amyjko amyjko added enhancement New or improved feature output Anything related to program output labels Sep 15, 2023
@amyjko amyjko changed the title Line barrier Line shape Sep 18, 2023
@amyjko amyjko added the starter A good issue for new contributors label Sep 18, 2023
@ryanngu023 ryanngu023 assigned ryanngu023 and unassigned ryanngu023 Oct 4, 2023
@wudel22 wudel22 moved this to Backlog in Management Oct 10, 2023
@wudel22 wudel22 removed this from Management Oct 10, 2023
@kaiden-ong kaiden-ong self-assigned this Oct 11, 2023
@iwangy iwangy self-assigned this Oct 11, 2023
@amyjko amyjko added this to the 1.0 milestone Oct 21, 2023
@iwangy iwangy removed their assignment Dec 13, 2023
@amyjko
Copy link
Collaborator Author

amyjko commented Dec 14, 2023

Hi @kaiden-ong and @ryanngu023,

It's the end of the quarter, so please post an update on this issue. Things to consider:

  • Should you still be the assignee? (If you're planning on working on it, yes! Submit a comment explaining your plans. If not, then unassign yourself, so others are eligible to grab it).
  • Do you have any work products that are hosted outside of GitHub? Embed them in this issue, so others can build off of them.
  • Are there any branches associated with this issue? Please link to them in the issue.

If there's nothing to change above, then at least post a comment indicating that you've seen this. Thanks!

@kaiden-ong
Copy link

Line shape/form has been created and recognized when writing Wordplay code. Temporary English locale has also been created. Future work includes rendering the image in ShapeView.svelte and generalizing to more shapes as it is hard coded right now for the Rectangle shape. @ryanngu023 and I will continue to work on this issue and will be the main point of contact. Planning to finish and submit PR in early Winter 2024 quarter.

@amyjko amyjko moved this to Backlog in Wordplay Backlog Dec 23, 2023
@amyjko amyjko moved this from Backlog to In Progress in Wordplay Backlog Dec 23, 2023
@ryanngu023 ryanngu023 linked a pull request Mar 1, 2024 that will close this issue
@amyjko
Copy link
Collaborator Author

amyjko commented Mar 15, 2024

It's the end of Winter! Please provide an update on this issue, including:

  • Whether you plan to continue work on it
  • If you do not, 1) provide a detailed update of its status, 2) add any unfinished work, 3) list any any unmerged branches, and 4) unassign yourself, so someone else can take over the task. Please leave the issue in better shape than you found it, helping future contributors to start from where you left off.

If you do plan to continue work on it, carry on. Otherwise, thank you for your contributions!

@ryanngu023
Copy link

We plan on continuing our work on this issue for the next quarter!

@amyjko
Copy link
Collaborator Author

amyjko commented Mar 18, 2024

Thanks for the update @ryanngu023!

@amyjko amyjko removed this from the 1.0 milestone May 24, 2024
@ryanngu023 ryanngu023 removed a link to a pull request Jun 3, 2024
@ryanngu023 ryanngu023 linked a pull request Jun 3, 2024 that will close this issue
@joonpiter
Copy link

Hi @ryanngu023 , are you still working on the following issue? I saw you opened a pull request at the start of June so I though I ask before removing you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature output Anything related to program output starter A good issue for new contributors
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

5 participants