Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure integrity values of notifications are base64 encoded #106

Closed
tomkralidis opened this issue Aug 17, 2023 · 4 comments
Closed

ensure integrity values of notifications are base64 encoded #106

tomkralidis opened this issue Aug 17, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@tomkralidis
Copy link
Collaborator

tomkralidis commented Aug 17, 2023

Users have reported that some notification messages properties.integrity.value values are not base64 encoded (per the WNM draft), even though they should be. Relevant reference implementations (wis2box, pywis-pubsub) should be updated accordingly.

Many thanks to @allanfrankwork for reporting the issue.

cc @kaiwirt @golfvert

@tomkralidis tomkralidis added the bug Something isn't working label Aug 17, 2023
@tomkralidis
Copy link
Collaborator Author

Updates:

@kaiwirt
Copy link

kaiwirt commented Aug 29, 2023

For GC Offenbach and WIS2 Node Offenbach we use the base64 encoding. However we also see WNM without this encoding. Input-wise we support both hex and base64

@golfvert
Copy link
Contributor

To be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants