Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KPI_7 results are 0/0 for all records #124

Open
amilan17 opened this issue Mar 15, 2022 · 5 comments
Open

KPI_7 results are 0/0 for all records #124

amilan17 opened this issue Mar 15, 2022 · 5 comments
Labels
Milestone

Comments

@amilan17
Copy link
Member

Summary and Purpose
None of the 120K+ records from DWD test site appear to have graphicOverview and we should investigate the reason and determine and, if relevant, the value of keeping this KPI.
Some potential explanations that should be explored:

  1. None of the records have //gmd:graphicOverview
  2. The test site doesn't have a complete set of records
  3. The Xpath is incorrect or too restrictive
  4. There's another bug in the pwcmp

Screenshot
Screenshot 2022-03-15 at 16 02 54
Screenshot 2022-03-15 at 16 06 19

@amilan17 amilan17 assigned tomkralidis and unassigned tomkralidis Mar 15, 2022
@amilan17 amilan17 changed the title KPI_007 results are 0/0 for all records KPI_7 results are 0/0 for all records Mar 15, 2022
@amilan17
Copy link
Member Author

amilan17 commented Mar 15, 2022

related to #94 #123

@amilan17 amilan17 added the kpi label Mar 15, 2022
@antje-s
Copy link

antje-s commented Mar 16, 2022

Hi Anna,

I took a look at a concrete example: urn:x-wmo:md:int.eumetsat:EO:EUM:DAT:MSG:AIRMASS

This metadata record includes text as link under gmd:graphicOverview

<gmd:graphicOverview>
  <gmd:MD_BrowseGraphic>
    <gmd:fileName>
        <gco:CharacterString>https://navigator.eumetsat.int/preview/0deg-airmass.jpg</gco:CharacterString>
    </gmd:fileName>
  </gmd:MD_BrowseGraphic>
</gmd:graphicOverview>

and KPI_7 result was:

"kpi_007": {
        "name": "KPI-7: Graphic overview for non bulletins metadata records",
        "total": 0,
        "score": 0,
        "comments": [],
        "percentage": null
    },

At the moment the code expects an Anchor under <gmd:fileName>

xpath = '//gmd:identificationInfo/gmd:MD_DataIdentification/gmd:graphicOverview/gmd:MD_BrowseGraphic/gmd:fileName/gmx:Anchor'

Example in documentation

        <gmx:Anchor xlink:href="https://navigator.eumetsat.int/preview/meteosat-msg_naturalenhncd.jpg">Meteosat MSG Natural Enhanced Color</gmx:Anchor>

And I assume that this affects several metadata sets in the same way. From the logic I also see the anchor as reasonable and better. Possibly one could be nevertheless less strict and also accept <gco:CharacterString>?

This should be discussed and decided by your team ;-)

@tomkralidis
Copy link
Collaborator

@wmo-im/tt-wismd for review/discussion at tomorrow's meeting.

@amilan17 amilan17 added this to the INFCOM-2 milestone Apr 6, 2022
@amilan17
Copy link
Member Author

@josusky -- was this fixed in pywcmp? I think it can be fixed by removing gmx:Anchor from the Xpath. 

 //gmd:identificationInfo/gmd:MD_DataIdentification/gmd:graphicOverview/gmd:MD_BrowseGraphic/gmd:fileName

@josusky
Copy link
Contributor

josusky commented Aug 15, 2022

@amilan17 I see action in the meeting notes https://github.com/wmo-im/tt-wismd/wiki/Meeting-2022-03-17 but not a decision. Perhaps the action should have been "create pywcmp issue" :-)
(The code change will be simple)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants