Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small tweaks #51

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Small tweaks #51

merged 5 commits into from
Mar 14, 2024

Conversation

RoryPTB
Copy link
Contributor

@RoryPTB RoryPTB commented Mar 14, 2024

The following changes have been made:

  • Station name is now truncated to 20 characters.
  • Redundant Docker image test files have been removed, since we no longer have a Dockerfile.
  • Removed duplicated pip install of pymetdecoder in tests.yml (as it is now on PyPI as pymetdecoder-wmo, see requirements.txt.
  • Updated version number to 0.7.0_dev

@RoryPTB RoryPTB requested a review from david-i-berry March 14, 2024 10:09
david-i-berry
david-i-berry requested changes Mar 14, 2024
View reviewed changes
synop2bufr/__init__.py
str: This name truncated to 20 characters.
"""
LOGGER.info(f"Truncating station name {name} to 20 characters")
return name[:20]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the name is only 10 characters long? Suggest adding a check.

@david-i-berry david-i-berry merged commit 5fedefe into main Mar 14, 2024
10 checks passed
@david-i-berry david-i-berry deleted the small-tweaks branch March 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-i-berry david-i-berry david-i-berry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RoryPTB @david-i-berry