-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Large file calls timing out #27
Comments
Not being an R user - is this a R system level issue, or something that our package itself can modify? |
If this is something you wanted to address, you could do something like:
which you'd insert wrapping around lines 229 to 234 in rgeoboundaries/R/utils.R. |
Thank you! That's incredibly helpful. |
Hi @noahdasanaike, Thank you for your suggestion! I've implemented the timeout modification as you described, and I've also replaced the cache functionality with a temporary approach. I've pushed these changes to the Git repository and tested them thoroughly. Everything seems to be working fine without any timeouts. Please feel free to test it out on your end and let us know if you encounter any issues or have any further feedback. Thanks again for your input, and I appreciate your ongoing support in improving the package! Best regards, |
There are a bunch of files large enough that for most users the download will time out under the R default. This could be fixed with a built-in time-out modification that's defaulted to true and optionally false. For instance,
rgeoboundaries::gb_adm1("Canada")
, which are hosted with Git LFS, are unlikely to download in the default 60 seconds and thus fail.The text was updated successfully, but these errors were encountered: