You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Add root objects to CDE Explorer's page context so we can have them pre-sorted alphabetically
- `gdown.download` doesn't raise an exception on error but returns None as the written filename, so test for this condition and raise our own exception (wkentaro/gdown#276)
- Make `update_nodes` "public" since we expect to call this from outside the class context
- When installing the CDE explorer, put it on the EDRN CDE page, not the LabCAS page. Also make it stand out. Also, initially populate it. Also, call it the "EDRN Data Model", not the "LabCAS CDEs"
- Make required CDEs stand out with color and icon
- Move the "Update from Google Drive" button appear next to the "View Update Log" button
- Hide the "Attributes" heading entirely if there are no attributes
Provide environment information
What OS are you using?
macOS 13.4
Describe the Bug
In some deeply embedded code, an autonomous system calls
and an unexpected error occurs later in the system when the supposedly downloaded file is read:
with the error:
The problem being that the file
fn
is actually empty. The real error is:We expected
gdown.download
to raise an exception on error.Expected Behavior
An exception to be raised on exceptional conditions.
Alternatively, the docstring should indicate how the return value is used to indicate exceptional conditions.
To Reproduce
gdown.download
that fileThe workaround is to do what
gdown.cli
does: check the return value and if it'sNone
, manually raise an exception.Otherwise, thanks so much for
gdown
! It's really quite superb otherwise 😇The text was updated successfully, but these errors were encountered: