-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move serial to a ros-* org ? #284
Comments
@wjwwood would you be open to adding maintainers to this project? |
I would also suggest adding @tonybaltovski and myself as maintainers.
Originally posted by @tonybaltovski in #209 (comment) |
Sorry, just getting to this. I'd be fine with forking it to ros-drivers and archiving this repository, but I don't want to move it. Also, I'd still like to see it renamed to avoid confusion a la ros-infrastructure/rep#379, but that would be up to future maintainers. |
To follow up on #285 (comment)... I just don't want to move it because then it doesn't show where it came from originally. Forking preserves the history of the repository in a more concrete way (in my opinion). I figure any issues worth moving could be moved with the fork and then maintained there. Part of forking would naturally be triaging the issues/prs. Afterwards I would close any issues or prs, pointing them at the fork and then archive the repo. Once moved, anyone can be made a maintainer without having to wait on me. We have processes in place to add/remove maintainers from the ros orgs. |
As for moving issues efficiently, you sadly cannot transfer issues across organizations, but we could consider making the fork on my account first, transferring issues, then moving the fork to ros-drivers. That's hacky, but might work. There's also https://github.com/gatewayapps/kamino, but I haven't investigated it thoroughly. I know that seems like busy work, but I do think it's better to get this in a common space if so many people are depending on it and want to contribute to it. I also believe that most of the issues are either out-of-date or invalid after so much time, and only a few are probably worth moving. So I don't think it's as bad as it sounds. |
Okay, Forking is fine, should we also rename it? or keep the original name and then you'll archive your repo? |
I think you should rename the package just because serial is too generic and presumptuous. A la the updates to REP-144, but since you're moving it to ros-drivers org, I'm not sure what it should be named. Maybe ros_drivers_serial? And that should be the package name, c++ namespace, and header file/folder structure. |
Originally posted by @SteveMacenski in #204 (comment)
The text was updated successfully, but these errors were encountered: