Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging CMAKE changes #252

Closed
Cazadorro opened this issue Aug 12, 2021 · 2 comments
Closed

Merging CMAKE changes #252

Cazadorro opened this issue Aug 12, 2021 · 2 comments

Comments

@Cazadorro
Copy link

@wjwwood Is it possible to have this merged? Our team currently relies on this change to even use this library, since we don't use Catkin at all. With out this we essentially have to maintain our own fork of this library until you do.

@wjwwood
Copy link
Owner

wjwwood commented Aug 12, 2021

I'm not planning on merging that, sorry. I would recommend you maintain your own fork for now.

There have been numerous similar pull requests/issues in the past. I will be moving away from catkin in the future, but I'll do that in the next major release. I don't know when I'll get to it, but I'll probably roll my own set of changes for updating to pure CMake.

@wjwwood wjwwood closed this as completed Aug 12, 2021
@wjwwood
Copy link
Owner

wjwwood commented Aug 12, 2021

I appreciate you opening the pull request though (even if you close it after my update), it might be useful to others in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants