From 0b9d5d5f9fbbf19f14549ce023a7548e3a35e198 Mon Sep 17 00:00:00 2001 From: Zachary Michaels Date: Mon, 11 Nov 2019 09:57:00 -0800 Subject: [PATCH] cast to unsigned for comparisons --- src/impl/list_ports/list_ports_linux.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/impl/list_ports/list_ports_linux.cc b/src/impl/list_ports/list_ports_linux.cc index 9779d5eb..bd67fff3 100644 --- a/src/impl/list_ports/list_ports_linux.cc +++ b/src/impl/list_ports/list_ports_linux.cc @@ -54,16 +54,16 @@ glob(const vector& patterns) glob_t glob_results; - int glob_retval = glob(patterns[0].c_str(), 0, NULL, &glob_results); + glob(patterns[0].c_str(), 0, NULL, &glob_results); vector::const_iterator iter = patterns.begin(); while(++iter != patterns.end()) { - glob_retval = glob(iter->c_str(), GLOB_APPEND, NULL, &glob_results); + glob(iter->c_str(), GLOB_APPEND, NULL, &glob_results); } - for(int path_index = 0; path_index < glob_results.gl_pathc; path_index++) + for(unsigned int path_index = 0; path_index < glob_results.gl_pathc; path_index++) { paths_found.push_back(glob_results.gl_pathv[path_index]); } @@ -243,7 +243,7 @@ format(const char* format, ...) { done = true; } - else if( return_value >= buffer_size_bytes ) + else if(static_cast(return_value) >= buffer_size_bytes) { // Realloc and try again.