Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game crashed when dragging on a scroll container. #208

Open
zly2006 opened this issue Dec 25, 2023 · 3 comments
Open

Game crashed when dragging on a scroll container. #208

zly2006 opened this issue Dec 25, 2023 · 3 comments
Labels
priority: normal this issue does not break any critical functionality - it must be adressed, but not immediately status: investigating this issue is not easily reproducible or fixable, the cause is being investigated type: question this issue asks a question and does not necessarily report a problem

Comments

@zly2006
Copy link

zly2006 commented Dec 25, 2023

Reproduce:
Dragging out of the screen

Screen recording:

QQ20231225-233644-HD.mp4

Crash report:

crash-2023-12-25_23.33.44-client.txt

My GUI:
https://github.com/zly2006/reden-is-what-we-made/blob/0e81abc89d4903a3cb356b622ced01824470a66d/src/main/java/com/github/zly2006/reden/debugger/gui/BreakpointListComponent.kt

I am not using stable owo versions, I built one from the 1.20.3 branch myself to develop mods on mc 1.20.4.

@zly2006
Copy link
Author

zly2006 commented Dec 25, 2023

Confirmed on the latest 1.20.3 branch.

@gliscowo
Copy link
Member

While I haven't reverse-engineered your entire screen, this problem smells strongly like you nested some part of your component hierarchy into itself - there isn't (or shouldn't be) any other way for this kind of infinite recursion to appear given the framework's implementation of the mouse dragging handler

Cheers

@gliscowo gliscowo added type: question this issue asks a question and does not necessarily report a problem priority: normal this issue does not break any critical functionality - it must be adressed, but not immediately status: investigating this issue is not easily reproducible or fixable, the cause is being investigated labels Jan 16, 2024
@zly2006
Copy link
Author

zly2006 commented Jan 16, 2024

Hmm, I attached the debugger and found that this here is a scroll container. When I drag the scrollbar out of the screen, it set scrollbaring to true the first time onMouseDrag is called, after that the mouse x/y coordinate is no longer inside the scrollbar, so onMouseDrag goes to super (BaseParentComponent), and it checks the focused element, but the element is scroll container itself.

So I believe it could be an owolib bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: normal this issue does not break any critical functionality - it must be adressed, but not immediately status: investigating this issue is not easily reproducible or fixable, the cause is being investigated type: question this issue asks a question and does not necessarily report a problem
Projects
None yet
Development

No branches or pull requests

2 participants