Hi,

As a workaround, to make the code cleaner, it seems that the Encryptable trait works fine.

@goldmont could you provide an example of what you tried to do that didn't work?

@goldmont could you provide an example of what you tried to do that didn't work?

Hi, sure.

test/archive/Plugin.php

public function registerSettings()
{
	return [
		'settings' => [
			'label' => 'test.archive::lang.models.settings.title',
			'description' => 'test.archive::lang.models.settings.description',
			'category' => 'test.archive::lang.menu.init',
			'icon' => 'icon-gear',
			'class' => Settings::class,
			'order' => 500,
			'keywords' => 'settings setup'
		]
	];
}

test/archive/models/settings/fields.yaml

fields:
  token:
    label: 'test.archive::lang.models.general.token'
    span: left
    type: sensitive

test/archive/models/Settings.php

<?php namespace Test\Archive\Models;

use Illuminate\Support\Facades\Crypt;
use Model;
use Winter\Storm\Database\Traits\Validation;

class Settings extends Model
{
	use Validation;

	public $implement = [\System\Behaviors\SettingsModel::class];

	public $settingsCode = 'test_archive_settings';

	public $settingsFields = 'fields.yaml';

	public $settingsCacheTtl = 0;

	public $rules = [];

	public function getTokenAttribute()
	{
		$value = $this->attributes['token'] ?? '';
		return !empty($value) ? Crypt::decrypt($value) : null;
	}

	public function setTokenAttribute($value): void
	{
		$this->attributes['token'] = Crypt::encrypt($value ?? '');
	}
}

The value set into $this->attributes gets lost before save. I had to implement beforeSave() method as I said before.

@mjauvin any ideas?

@LukeTowers most likely caused by the changes in priority made in this PR

I tested above suspicion and looks like this is not the cause. Still investigating.

I reverted back to winter 1.2.1 and the bavior is till the same, so this has either never worked properly or it's been broken for a long time.

@goldmont see if #1069 resolves the issue for you, it does in my testing.

@goldmont see if #1069 resolves the issue for you, it does in my testing.

Hi @mjauvin,

thank you for helping me. On my side, the value returned by the mutator is now somehow ignored.

null value is persisted in fact. Let me know if I should test something else

@goldmont can you show your mutator code ?

@goldmont can you show your mutator code ?

It's like the one in the Mutators documentation:

public function setFirstNameAttribute($value)
{
	$this->attributes['first_name'] = Crypt::encrypt($value ?? '');
}

I read the code you wrote. I think I have to return the value instead of assigning it.

By the way I can confirm that the following code works to me too:

public function setFirstNameAttribute($value)
{
	return Crypt::encrypt($value ?? '');
}

Brain cramp alert!

I swapped mutator with accessor in my mind... ignore everything I said and did so far... 🙄

@goldmont Ok, try PR #1071

@goldmont Ok, try PR #1071

I can confirm that it works properly now. Thanks!

This will be closed automatically when the PR is merged.