Issue: Repeated magic string.

[CjHare]

With the same addresses (hardcoded strings) used throughout, replacing all instances with module level constant helps with readability & maintainability.

windranger-treasury-subgraph/tests/bondMediator.test.ts

Line 101 in 65c4883

const instigator = Address.fromString('0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266');

  const INSTIGATOR = Address.fromString('0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266');

....

  handleAddCollateralWhitelist(
    new AddCollateralWhitelist(
      Address.fromString(BOND_MEDIATOR_ADDRESS),
      defaultBigInt,
      defaultBigInt,
      defaultLogType,
      newBlock(),
      newTransaction(INSTIGATOR.toHex()),
      [
        new ethereum.EventParam('daoId', ethereum.Value.fromI32(DAO_ID)),
        new ethereum.EventParam(
          'collateralTokens',
          ethereum.Value.fromAddress(treasuryAddress)
        ),
        new ethereum.EventParam('instigator', ethereum.Value.fromAddress(INSTIGATOR))
      ],
      null
    )
  );

....

  handleAdminChanged(
    new AdminChanged(
      Address.fromString(BOND_MEDIATOR_ADDRESS),
      defaultBigInt,
      defaultBigInt,
      defaultLogType,
      newBlock(),
      newTransaction(INSTIGATOR.toHex()),
      [
        new ethereum.EventParam(
          'previousAdmin',
          ethereum.Value.fromAddress(previousAdmin)
        ),
        new ethereum.EventParam('newAdmin', ethereum.Value.fromAddress(newAdmin))
      ],
      null
    )
  );

[grezle]

This is true, I can take a look at this, but as everything is reset between runs, I don't expect to pick up any results from previous runs. The address that we pass in only matter for the lifecycle of the test. It might help with readability to bring these values closer to the test though.