Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Matt's repo to this one #581

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Feb 6, 2024

Fixes: #559

Dear @nijel @mchaput @stevennic @ZeroCool940711

The only difference between master and @mchaput's main branch is this single commit mchaput/whoosh@d9a3fa2

-        elif fixedsize is 0:
+        elif fixedsize == 0:

Steps used to create this pull request:
% git remote add mchaput https://github.com/mchaput/whoosh
% git remote -v

mchaput	https://github.com/mchaput/whoosh (fetch)
mchaput	https://github.com/mchaput/whoosh (push)
origin	https://github.com/cclauss/whoosh (fetch)
origin	https://github.com/cclauss/whoosh (push)
upstream	https://github.com/whoosh-community/whoosh (fetch)
upstream	https://github.com/whoosh-community/whoosh (fetch)

% git fetch mchaput
% git checkout mchaput/main
% git switch -c mchaput-main
% git push upstream


https://github.com/django-haystack/django-haystack contains support for the Whoosh backend however

has not received support from other maintainers so I am working to get a modernized, tested version of Whoosh.

I would like to resolve the uncertainty around #559 and add continuous integration tests via #579.

Can one of you please review and land these two PRs and help me get a release to https://pypi.org/project/Whoosh ?
If there is no interest, can you please make me a maintainer of this repo and add me to the list of PyPI maintainers?

You should compare to an int using == not is (even though technically the int is implemented as a singleton object).
Not sure how or why I typed this originally.
Thanks to Philipp Kolmann for pointing this out.
@nijel
Copy link
Collaborator

nijel commented Feb 8, 2024

Thanks for comparing the repos! But what I've stated in #579 (comment) still holds. Let's see how #561 ends up.

@cclauss cclauss closed this Aug 13, 2024
@cclauss cclauss deleted the mchaput-main branch August 13, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please help Matt sync up the repos
3 participants