Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart Tale on a stopped Tale yields a 500 #601

Open
bodom0015 opened this issue Feb 20, 2020 · 2 comments
Open

Restart Tale on a stopped Tale yields a 500 #601

bodom0015 opened this issue Feb 20, 2020 · 2 comments

Comments

@bodom0015
Copy link
Member

bodom0015 commented Feb 20, 2020

We should probably disable the "Restart Tale" dropdown option if the Tale isn't running

Steps to Reproduce

  1. Login to the WholeTale Dashboard
  2. Create a Tale, but don't launch it
  3. Navigate to the Run view for the Tale
  4. Expand the dropdown at the top-right and select Restart Tale

Expected Results
Nothing should happen - there is no Tale to restart.
Dropdown option should probably be disabled in this case.

Actual Results
The API server throws a 500.

@bodom0015
Copy link
Member Author

Since you can't Restart without hitting Run first, I propose moving "Restart" to be in-line with Run and Close. That way, it will make sense to show/hide this option as the Tale state changes (unlike the items in the current dropdown list)

If this would take up too much space on the paddleboard, we can always use a dropdown action selector, similar to the "Create and Launch Tale" behavior on the create-tale-modal.

@bodom0015
Copy link
Member Author

bodom0015 commented Mar 4, 2020

Kyle and others reported this at the 2020 AHM.

Also noting that this option (as well as "Rebuild Tale") show for Tale's that the user does not own.

These options should be disabled (or ideally, hidden entirely) in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant