Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve all the wallets in the account #842

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mominafiz
Copy link
Contributor

@mominafiz mominafiz commented Mar 9, 2024

Description

The default page size of 50 records may miss the wallet with funds, resulting in an 'Insufficient funds' error. This is an edge case as the error is only seen when a user has selected all the wallets when creating an API key.

Currently, Coinbase lists around 70 wallets and when increasing the page size to 250 the error is resolved. However, this is valid until the number of wallets is more than the maximum page size.

Type of change

Please make your selection.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a new dependency
  • Code Maintainability / comments
  • Code Refactoring / future-proofing

How Has This Been Tested?

Manual live run of the bot using Coinbase Exchange and API keys.

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added pytest unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

The default page size of 50 records may miss the wallet with funds
which results in 'Insufficient funds' error. Currently, Coinbase
list around 70 wallets and using maximum page size of 250 avoid the
funds error. However, this is a temporary fix; until they add more
than 250 wallets. This is an edge case as well and the error is only
seen when a user has selected all the wallets when creating an API
keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant