Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing Coinbase exchange in Telegram Bot and minimum quote order #840

Merged

Conversation

mominafiz
Copy link
Contributor

Description

The Telegram bot doesn't display 'Coinbase' as the exchange and it seems it was intentionally left out due to an error in minimum_order_quote(). Reading the base_min_size in the response of the product API call fixes the issue and the bot
starts successfully. The orders are placed for both buy and sell, though there is another uncaught exception that exits the bot. It is related to _trading_data used before initialization which is out-of-scope of this change.

Partially Fixes #832

Type of change

Please make your selection.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a new dependency
  • Code Maintainability / comments
  • Code Refactoring / future-proofing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added pytest unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@whittlem whittlem changed the base branch from main to beta March 4, 2024 10:05
@whittlem whittlem merged commit 5be74cf into whittlem:beta Mar 4, 2024
@whittlem
Copy link
Owner

whittlem commented Mar 4, 2024

@mominafiz, thanks for your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Coinbase API grabbing Quote Currency
2 participants