Fix: missing Coinbase exchange in Telegram Bot and minimum quote order #840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Telegram bot doesn't display 'Coinbase' as the exchange and it seems it was intentionally left out due to an error in minimum_order_quote(). Reading the
base_min_size
in the response of the product API call fixes the issue and the botstarts successfully. The orders are placed for both buy and sell, though there is another uncaught exception that exits the bot. It is related to
_trading_data
used before initialization which is out-of-scope of this change.Partially Fixes #832
Type of change
Please make your selection.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: