Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for orders in json format #552

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

byymster
Copy link

@byymster byymster commented Nov 4, 2021

Description

While using bot in Kubernetes you lost observability of making orders. Write trades.csv and collect it somehow is not a case.
Write needed logs in JSON format is best approach. In this case you can collect BUY and SELL logs via ELK stack or something similar(like Google Stackdriver) and then use it in some monitoring system(like Grafana)

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please make your selection.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a new dependency
  • Code Maintainability / comments
  • Code Refactoring / future-proofing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added pytest unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@edrickrenan
Copy link
Collaborator

It may be worth adding this config to https://github.com/whittlem/pycryptobot/blob/main/models/ConfigBuilder.py

@byymster
Copy link
Author

byymster commented Nov 4, 2021

It may be worth adding this config to https://github.com/whittlem/pycryptobot/blob/main/models/ConfigBuilder.py

it's for init command, right?

@edrickrenan
Copy link
Collaborator

It may be worth adding this config to https://github.com/whittlem/pycryptobot/blob/main/models/ConfigBuilder.py

it's for init command, right?

Yes

Copy link
Owner

@whittlem whittlem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@whittlem whittlem merged commit 6da2c93 into whittlem:beta Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants