Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With bringing in environs should the get_user_settings_from_env function at the top of the file be rethought? #69

Closed
jefftriplett opened this issue Oct 25, 2023 · 1 comment
Closed

With bringing in environs should the get_user_settings_from_env function at the top of the file be rethought? #69

jefftriplett opened this issue Oct 25, 2023 · 1 comment

Comments

@jefftriplett
Copy link
Contributor

jefftriplett commented Oct 25, 2023 •
edited by joshuadavidthomas
Loading

Looks good. With bringing in environs should the get_user_settings_from_env function at the top of the file be rethought?

Originally posted by @joshuadavidthomas in #68 (review)
@jefftriplett jefftriplett changed the title Looks good. With bringing in environs should the get_user_settings_from_env function at the top of the file be rethought? With bringing in environs should the get_user_settings_from_env function at the top of the file be rethought? Oct 25, 2023
@joshuadavidthomas
Copy link
Member

Pending #154 and the expansion of the relay service into a full fledged application, I think I'm going to close this for now. As part of it, we will most certainly bring in environs since that's the pattern we're most comfortable with @westerveltco.

@joshuadavidthomas joshuadavidthomas closed this as not planned Won't fix, can't repro, duplicate, stale May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jefftriplett @joshuadavidthomas