Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another CRAN release needed: not compatible with arrow #391

Open
rorynolan opened this issue Jan 28, 2021 · 2 comments
Open

Another CRAN release needed: not compatible with arrow #391

rorynolan opened this issue Jan 28, 2021 · 2 comments

Comments

@rorynolan
Copy link

The current CRAN feather package is saying valid feather files are not valid because the current CRAN arrow package is ahead of it.

packageVersion("feather")
#> [1] '0.3.5'
packageVersion("arrow")
#> [1] '3.0.0'
tmp_feather <- tempfile(fileext = ".feather")
arrow::write_feather(iris, tmp_feather)
df <- arrow::read_feather(tmp_feather)
feather::read_feather(tmp_feather)
#> Error in openFeather(path): Invalid: Not a feather file

Created on 2021-01-27 by the reprex package (v1.0.0)

I can see that in the dev version here on GitHub you've already done the sensible thing and just wrapped arrow.
I think this should be released to CRAN. Happy to do this for you with your permission. Have submitted to CRAN plenty of times.

@nealrichardson
Copy link
Collaborator

Leaving aside the question of whether there should be a feather release to CRAN, the problem in your code is that arrow writes Feather V2 by default, and the current feather package is V1 only. arrow::write_feather(iris, tmp_feather, version = 1) would be readable by the feather package as it stands on CRAN (and both would be readable with the dev version of feather since it is just a wrapper around arrow).

flor14 added a commit to flor14/breast_cancer_predictor that referenced this issue Oct 29, 2021
@IndrajeetPatil
Copy link

There might be a CRAN update necessary also to address the issues found in CRAN's additional checks:

https://raw.githubusercontent.com/kalibera/cran-checks/master/rchk/results/feather.out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants