Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Selectable font-family #887

Open
yuki-takei opened this issue Apr 3, 2019 · 2 comments
Open

Feature: Selectable font-family #887

yuki-takei opened this issue Apr 3, 2019 · 2 comments

Comments

@yuki-takei
Copy link
Member

yuki-takei commented Apr 3, 2019

TODO

/admin/customize

  • Add radio button to select System Default Font

    • preset 1: font-family: Lato, sans-serif;
    • preset 2: font-family: Lato, 'Noto Sans JP', sans-serif;
    • custom
  • Add checkbox Allow customize font by users

  • Add radio button to select System Default Monospace Font

    • preset 1: font-family: Roboto Mono, monospace;
    • preset 2: font-family: Roboto Mono, 'MS Gothic', monospace;
    • custom
  • Add checkbox Allow customize font by users

/me

  • Add radio button to select Default Font

    • Use System Default Font
    • preset 1: font-family: Lato, sans-serif;
    • preset 2: font-family: Lato, 'Noto Sans JP', sans-serif;
    • custom
  • Add radio button to select Default System Monospace Font

    • Use System Default Monospace Font
    • preset 1: font-family: Roboto Mono, monospace;
    • preset 2: font-family: Roboto Mono, 'MS Gothic', monospace;
    • custom

Create a swig widget to add <link> tag

  • Load google fonts according to selected system fonts and selected user custom fonts
    • weight: 400 and 700

Migration

  • Set system font-family according to the system language

IssueHunt Summary

Backers (Total: $0.00)

Become a backer now!

Or submit a pull request to get the deposits!

Tips

@yaodingyd
Copy link
Contributor

Is the preset font added to style like how custom css is added to style? https://github.com/weseek/growi/blob/master/src/server/views/layout/layout.html#L104

@yuki-takei
Copy link
Member Author

yuki-takei commented Apr 23, 2019

Is the preset font added to style like how custom css is added to style?

Yes, the preset font styles (font-family: specifications) must be injected into a swig file somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants