Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bootstrap-table-filter-control versions >= 1.20.0 are much slower #6222

Closed
UselessGuru opened this issue Jun 20, 2022 · 4 comments
Closed

bootstrap-table-filter-control versions >= 1.20.0 are much slower #6222

UselessGuru opened this issue Jun 20, 2022 · 4 comments
Assignees
@djhvscf
Labels
Bug Issues which are marked as Bug duplicate Issues that are duplicated with other issues. filter-control Issues for the filter-control extension.

Comments

@UselessGuru
Copy link

UselessGuru commented Jun 20, 2022 •
edited
Loading

Bootstraptable version(s) affected

>=1.20.0

Description

All bootstrap-table-filter-control versions newer than 1.18.3 are very slow.
I takes a few seconds to fill in the filter control. V 1.18.3 (and older) are much faster.
Furthermore the filter control values are not sorted.

Can anyone confirm?
What am I doing wrong? All sources can be found here: https://github.com/Minerx117/NemosMiner/tree/master/Web
@UselessGuru UselessGuru added the Bug Issues which are marked as Bug label Jun 20, 2022
@UselessGuru UselessGuru changed the title new bootstrap-table-filter-control versions much slower than 0.18.3 new bootstrap-table-filter-control versions much slower than 1.18.3 Jun 20, 2022
@UselessGuru UselessGuru changed the title new bootstrap-table-filter-control versions much slower than 1.18.3 bootstrap-table-filter-control versions newer than 1.18.3 are much slower Jun 20, 2022
@UselessGuru UselessGuru changed the title bootstrap-table-filter-control versions newer than 1.18.3 are much slower bootstrap-table-filter-control versions >= 1.20.0 are much slower Jul 1, 2022
@UselessGuru
Copy link
Author

UselessGuru commented Jul 1, 2022 •
edited
Loading

Seems related to
#6201 Permits "filter-control" select box ordering by alphabetic order
However in my case the dropdown data get sorted. I assume this is the case for the performance impact.

Maybe re-adding the pre-1.20.x code will fix this.

@djhvscf
Copy link
Collaborator

djhvscf commented Aug 2, 2022

@UselessGuru we need to continue working on the performance of this extension. Do you have any examples where we can play with the performance issue that you're facing?

@djhvscf djhvscf self-assigned this Aug 2, 2022
@djhvscf djhvscf added the filter-control Issues for the filter-control extension. label Aug 2, 2022
@djhvscf
Copy link
Collaborator

djhvscf commented Aug 3, 2022

Working on this PR #6309

@djhvscf
Copy link
Collaborator

djhvscf commented Aug 3, 2022

Duplicated ##5777

@djhvscf djhvscf closed this as completed Aug 3, 2022
@djhvscf djhvscf added the duplicate Issues that are duplicated with other issues. label Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djhvscf djhvscf

Labels
Bug Issues which are marked as Bug duplicate Issues that are duplicated with other issues. filter-control Issues for the filter-control extension.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djhvscf @UselessGuru