From fa4105b3f5af7fceb1d1655fa80313db95bb1588 Mon Sep 17 00:00:00 2001 From: jamie Date: Thu, 11 Apr 2024 12:31:30 +0100 Subject: [PATCH 1/2] Enable requesting for somja --- .../source_model/sierra/rules/SierraRulesForRequesting.scala | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/common/source_model/src/main/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequesting.scala b/common/source_model/src/main/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequesting.scala index ed82c01212..775609abbd 100644 --- a/common/source_model/src/main/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequesting.scala +++ b/common/source_model/src/main/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequesting.scala @@ -35,7 +35,8 @@ import weco.sierra.models.data.SierraItemData * https://documentation.iii.com/sierrahelp/Content/sril/sril_records_varfld_types_item.html * * This was last checked against Sierra based on a set of rules provided by - * Natalie Pollecutt on 8th February 2024 + * Louise Simon on 20th March 2024 + * https://wellcome.slack.com/archives/C3TQSF63C/p1710937847843969 */ object SierraRulesForRequesting { def apply(itemData: SierraItemData): RulesForRequestingResult = @@ -279,7 +280,6 @@ object SierraRulesForRequesting { // v|i||79||=|sgmoh|| // v|i||79||=|somet|| // v|i||79||=|somge|| - // v|i||79||=|somja|| // v|i||79||=|sompr|| // q|i||79||=|somsy||Please complete a manual request slip. This item cannot be requested online. // @@ -302,7 +302,6 @@ object SierraRulesForRequesting { "sgmoh", "somet", "somge", - "somja", "sompr", "somsy" ) => From ebf8921b4e061bffd9f1a29121f0eb6362b1a6b8 Mon Sep 17 00:00:00 2001 From: jamie Date: Thu, 11 Apr 2024 14:07:01 +0100 Subject: [PATCH 2/2] Fix tests --- .../source_model/sierra/rules/SierraRulesForRequestingTest.scala | 1 - 1 file changed, 1 deletion(-) diff --git a/common/source_model/src/test/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequestingTest.scala b/common/source_model/src/test/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequestingTest.scala index 3dcd92556c..43ed103570 100644 --- a/common/source_model/src/test/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequestingTest.scala +++ b/common/source_model/src/test/scala/weco/catalogue/source_model/sierra/rules/SierraRulesForRequestingTest.scala @@ -175,7 +175,6 @@ class SierraRulesForRequestingTest "sgmoh", "somet", "somge", - "somja", "sompr", "somsy")