Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recvMessageLoop has an infinite buffer #176

Open
edsko opened this issue Jul 2, 2024 · 1 comment
Open

recvMessageLoop has an infinite buffer #176

edsko opened this issue Jul 2, 2024 · 1 comment
Labels
enhancement New feature or request priority: low Minor enhancements

Comments

@edsko
Copy link
Collaborator

edsko commented Jul 2, 2024

A hostile client could make a server run out of memory by sending a single enormous gRPC message. We should have a configurable bound on the max message size, and kill a connection when this message size is exceeded.

(NON-option: we cannot impose a maximum memory size "overall"; if we have multiple connections, we might end up with all connections having read "half a message", then hit the limit, and the system unable to make any further progress.)

@edsko edsko added enhancement New feature or request priority: medium Should be done before the library can be considered complete labels Jul 2, 2024
@edsko
Copy link
Collaborator Author

edsko commented Jul 3, 2024

Marking as low priority as we do not currently care about protection against DDoS.

@edsko edsko added priority: low Minor enhancements and removed priority: medium Should be done before the library can be considered complete labels Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low Minor enhancements
Projects
None yet
Development

No branches or pull requests

1 participant