Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep open after --execute -x option? #80

Open
kevzettler opened this issue Aug 31, 2018 · 2 comments
Open

Keep open after --execute -x option? #80

kevzettler opened this issue Aug 31, 2018 · 2 comments

Comments

@kevzettler
Copy link

Seems like the connection closes immediately after invoking with the -x option?

passing -w seems allows for arbitrarily specifying a wait time. Is there a way to keep open after -x ?

@Xdomen
Copy link

Xdomen commented Nov 26, 2020

Hey, any update on this issue? I would really appreciate it if the connection wouldn't close whenever you use the -x option

@techygrrrl
Copy link

I'd also like this feature 😄

It looks like someone opened a PR related to this but it also does other things: #114

The main concern seems to be in this area of the code where the wait and close logic is tightly coupled to executing a command—if you don't provide a wait flag, it closes after 2 seconds of sending a command. It should just be kept open instead if you don't provide a wait flag. You can't pass a large number either otherwise it overflows. This logic should be changed.

https://github.com/websockets/wscat/blob/5.2.0/bin/wscat#L276-L283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants