-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offline tests #133
Comments
Would you mind submitting this patch as a PR based on the solution you suggest? :) It seems like that's fairly close to what you have already since you'e identified the tests that need to be excluded, just need to then add an offline flag (https://github.com/FPGAwars/apio/blob/develop/test/conftest.py#L32) and changing the skip to check the flag like https://github.com/FPGAwars/apio/blob/develop/test/packages/test_api.py#L7 Since you've already written most of it, hopefully something that can be quick? Thanks, and we can merge it into a new release. |
To be honest, I don't know anything about pytest but I'll try. |
I'm packaging this library in Nixpkgs. The sandbox in which all packages are built has no internet connectivity to achieve reproducibility. This causes some tests to fail. It would be nice to have a
--offline
flag for pytest that skips all tests, that require internet connectivity. The unrelated project https://github.com/FPGAwars/apio for example has such a flag (for inspiration). At the moment I'm patching the source to manually remove the failing tests, which is a bit ugly and will break if there are changes in the wrong places in the code in the future. Other packaging efforts may also benefit from such a flag.Patch
The text was updated successfully, but these errors were encountered: