Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat improve local devex #1827

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

osintalex
Copy link

Addresses a few issues I encountered while getting everything spun up for local dev before tackling first issues:

  • A few things I couldn't find in the docs when getting the UI set up to run locally with yarn
  • How to get hot reloading on the backend API while keeping it in kubernetes.

I don't think it would be too much work from here to get remote debugging on the k8s pod running the API set up too. Skaffold has pretty good integrations on that.

Happy to also take a look at that if there is interest.

skaffold.yaml Show resolved Hide resolved
@osintalex
Copy link
Author

osintalex commented May 27, 2024

Added in interactive debugging with VSCode in last commit too. Didn't really work out of the box with Skaffold. It is more aimed than I realised at doing everything in GCP (requires you to sign into a GCP account even to debug on a local cluster 😢). So I dropped that in favour of debugpy, which imo is preferable anyway since it's open source.

@tw4l
Copy link
Member

tw4l commented May 27, 2024

Added in interactive debugging with VSCode in last commit too. Didn't really work out of the box with Skaffold. It is more aimed than I realised at doing everything in GCP (requires you to sign into a GCP account even to debug on a local cluster 😢). So I dropped that in favour of debugpy, which imo is preferable anyway since it's open source.

Sounds great, thank you! Will do some local testing tomorrow :) Appreciate this contribution!

@vnznznz
Copy link
Contributor

vnznznz commented Jun 4, 2024

Tried this for a bit, being able to debug the backend code is great! Unfortunately I was unable to get theop container in the backend pod to auto-update too. I also encountered some weird internal k8s 404 errors when updating files in chart/app-templates requiring me to reset the cluster. Also tried building frontend with skaffold, had to enable useDockerCLI to get it to work.

@osintalex
Copy link
Author

osintalex commented Jun 26, 2024 via email

@vnznznz
Copy link
Contributor

vnznznz commented Jul 1, 2024

What's the expected behaviour here, do you want file sync and debuggability on the op container too? I didn't add any config for that.

Since they share a codebase I think they should update in sync. Several times while testing skaffold I got in this situation where I tried to troubleshoot an error and didn't realize my changes weren't applied 😅

Having frontend in there is not necessary imo.

@ikreymer
Copy link
Member

ikreymer commented Jul 3, 2024

@osintalex Thank you so much for your work on this! Agree with @vnznznz, let's add the op container reloading as well, otherwise it'll be a bit confusing to work on the backend if they get out of sync. No need for frontend, as we already have local loading with yarn for that.

@osintalex osintalex force-pushed the feat-improve-local-devex branch from 1e89968 to 3f68050 Compare July 13, 2024 12:56
@osintalex
Copy link
Author

Makes sense! I've added hot reload and debugger support for the op container now ☺️

@osintalex
Copy link
Author

Bump :-)

@osintalex osintalex force-pushed the feat-improve-local-devex branch from de0c6ed to 01a0303 Compare August 4, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants