-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat improve local devex #1827
base: main
Are you sure you want to change the base?
Feat improve local devex #1827
Conversation
Added in interactive debugging with VSCode in last commit too. Didn't really work out of the box with Skaffold. It is more aimed than I realised at doing everything in GCP (requires you to sign into a GCP account even to debug on a local cluster 😢). So I dropped that in favour of |
Sounds great, thank you! Will do some local testing tomorrow :) Appreciate this contribution! |
Tried this for a bit, being able to debug the backend code is great! Unfortunately I was unable to get the |
Sorry for slow reply. What's the expected behaviour here, do you want file sync and debuggability on the op container too? I didn't add any config for that.
I also didn't add any config for the frontend since it looked much easier to me to just run it locally with yarn and then hit the backend after portforwarding to localhost. I haven't tried this, but my get is that it will be hard to get hot reload with the frontend unless you add a different dev Dockerfile that doesn't use a multistage build.
I think expected behaviour of file sync + debugger on the op container while running frontend locally and then hitting a port-forwarded backend would probably be the best expected behaviour. Lmk if I'm missing anything though.
…On Tuesday, June 4th, 2024 at 7:59 AM, Vinzenz Sinapius ***@***.***> wrote:
Tried this for a bit, being able to debug the backend code is great! Unfortunately I was unable to get theop container in the backend pod to auto-update too. I also encountered some weird internal k8s 404 errors when updating files in chart/app-templates requiring me to reset the cluster. Also tried building frontend with skaffold, had to enable [useDockerCLI](https://skaffold.dev/docs/references/yaml/#build-local-useDockerCLI) to get it to work.
—
Reply to this email directly, [view it on GitHub](#1827 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/APHRW4T7I7MEOIVFXRO2UODZFVQVFAVCNFSM6AAAAABILQ4O6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBWG42TINBRGI).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Since they share a codebase I think they should update in sync. Several times while testing skaffold I got in this situation where I tried to troubleshoot an error and didn't realize my changes weren't applied 😅 Having frontend in there is not necessary imo. |
@osintalex Thank you so much for your work on this! Agree with @vnznznz, let's add the op container reloading as well, otherwise it'll be a bit confusing to work on the backend if they get out of sync. No need for frontend, as we already have local loading with yarn for that. |
1e89968
to
3f68050
Compare
Makes sense! I've added hot reload and debugger support for the op container now |
Bump :-) |
de0c6ed
to
01a0303
Compare
Addresses a few issues I encountered while getting everything spun up for local dev before tackling first issues:
I don't think it would be too much work from here to get remote debugging on the k8s pod running the API set up too. Skaffold has pretty good integrations on that.
Happy to also take a look at that if there is interest.