Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a copy option to copy relative symbolic links without resolving. #381

Open
PabloK opened this issue May 17, 2019 · 12 comments
Open

Add a copy option to copy relative symbolic links without resolving. #381

PabloK opened this issue May 17, 2019 · 12 comments

Comments

@PabloK
Copy link

PabloK commented May 17, 2019

  • Operating System: N/A
  • Node Version: N/A
  • NPM Version: N/A
  • webpack Version: 4
  • copy-webpack-plugin Version: 5.0.3

Feature Proposal

Add an option to copy-webpack-plugin to copy relative symbolic links without resolving the underlying structure.

Feature Use Case

An example repo can be found here: https://github.com/PabloK/copy-webpack-381

@PabloK PabloK changed the title Copy relative symbolic links without resolving. Add a copy option to copy relative symbolic links without resolving. May 17, 2019
@marco-a
Copy link

marco-a commented May 18, 2019

Yes, please!

@alexander-akait
Copy link
Member

PR welcome

@PabloK
Copy link
Author

PabloK commented May 24, 2019

I have started a PR on this so far only a failing test. It can be found here. Would be glad to have some review of the test as I'm new to the testing style you use.

https://github.com/PabloK/copy-webpack-plugin

@alexander-akait
Copy link
Member

@PabloK please send a PR and i will review and say what is wrong

@marco-a
Copy link

marco-a commented May 25, 2019

What's "confusing" the task seems pretty clear to me?

@alexander-akait
Copy link
Member

My mistake

@iEchoic
Copy link

iEchoic commented Jun 2, 2019

👍 just wanted to mention that this is important when using libraries like sharp, which resolve dependencies with local symlinks.

@alexander-akait
Copy link
Member

PR welcome

@alexander-akait
Copy link
Member

I think we don't need this option, because https://github.com/mrmlnc/fast-glob#followsymboliclinks

@alexander-akait
Copy link
Member

I will add tests and docs

@alexander-akait
Copy link
Member

Bug on fast-glob side

@alexander-akait
Copy link
Member

Found other bugs on our side, but we need to solve mrmlnc/fast-glob#300 firstly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants