Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reverse operator #773

Open
huningxin opened this issue Oct 29, 2024 · 1 comment
Open

Support reverse operator #773

huningxin opened this issue Oct 29, 2024 · 1 comment

Comments

@huningxin
Copy link
Contributor

This operator reverses the order of the input tensor along specified axes. There are some pytorch models using flip operator. When they target WebNN, the flip/reverse operator get fallback to other execution providers and cause performance drop.

Frameworks' support

  • PyTorch flip
  • TensorFlow reverse
  • ONNX Slice support reverse slicing by setting step to -1

Native ML API's support

Proposal

dictionary MLReverseOptions : MLOperatorOptions {
  sequence<[EnforceRange] unsigned long> axes;
};
 
MLOperand reverse(MLOperand input, optional MLReverseOptions options = {});

Discussed with @fdwr offline, Dwayne recommended treating the axes similar to reduce operators. So if not provided at all, then all axes are reversed; but if explicitly passed as empty, then no axes are reversed.

@fdwr
Copy link
Collaborator

fdwr commented Oct 29, 2024

Signature looks good to me Ningxin. 👍

Also related:

  • StableHLO reverse
  • tosa.reverse (mlir::tosa::ReverseOp)
  • ANEURALNETWORKS_REVERSE
  • PyTorch prims rev

(historical trivia) There was actually an ONNX Reverse operator here briefly, but it was rushed before all the feedback was addressed and reverted, and then it appears Peyman never followed up with an updated version. 🤷‍♂️. (I've also thought about adding a DML_OPERATOR_REVERSE before, but didn't get to it as I didn't know a clear model that used it)

chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 6, 2024
This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 8, 2024
This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
aarongable pushed a commit to chromium/chromium that referenced this issue Nov 13, 2024
This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382078}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 13, 2024
This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382078}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 13, 2024
This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382078}
aarongable pushed a commit to chromium/chromium that referenced this issue Nov 13, 2024
This reverts commit 0459ac1.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Yoichi Osato <[email protected]>
Auto-Submit: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382142}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 13, 2024
This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Yoichi Osato <[email protected]>
Auto-Submit: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382142}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 13, 2024
This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Yoichi Osato <[email protected]>
Auto-Submit: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382142}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 15, 2024
…tonly

Automatic update from web-platform-tests
webnn: implement reverse operator

This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382078}

--

wpt-commits: 84f13be63d17cb4e6152782dc3fb4d49fb2842b5
wpt-pr: 49011
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 15, 2024
…r", a=testonly

Automatic update from web-platform-tests
Revert "webnn: implement reverse operator"

This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Yoichi Osato <[email protected]>
Auto-Submit: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382142}

--

wpt-commits: 29bbccab8983b550c40cc394a398123a638d4223
wpt-pr: 49134
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 16, 2024
This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf

The previous CL got reverted because another CL[1] changed the function
name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL
fixes the name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 16, 2024
…tonly

Automatic update from web-platform-tests
webnn: implement reverse operator

This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <ningxin.huintel.com>
Auto-Submit: Shiyi Zou <shiyi.zouintel.com>
Reviewed-by: Austin Sullivan <asullychromium.org>
Reviewed-by: ningxin hu <ningxin.huintel.com>
Cr-Commit-Position: refs/heads/main{#1382078}

--

wpt-commits: 84f13be63d17cb4e6152782dc3fb4d49fb2842b5
wpt-pr: 49011

UltraBlame original commit: 60b2e3d5b43a1d85b6ef1d04b7b2e9d6a2cda530
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Nov 16, 2024
…r", a=testonly

Automatic update from web-platform-tests
Revert "webnn: implement reverse operator"

This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <ningxin.huintel.com>
> Auto-Submit: Shiyi Zou <shiyi.zouintel.com>
> Reviewed-by: Austin Sullivan <asullychromium.org>
> Reviewed-by: ningxin hu <ningxin.huintel.com>
> Cr-Commit-Position: refs/heads/main{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Reviewed-by: Yoichi Osato <yoichiochromium.org>
Owners-Override: Yoichi Osato <yoichiochromium.org>
Auto-Submit: Yoichi Osato <yoichiochromium.org>
Cr-Commit-Position: refs/heads/main{#1382142}

--

wpt-commits: 29bbccab8983b550c40cc394a398123a638d4223
wpt-pr: 49134

UltraBlame original commit: 107faff7e65875aa46d6e2b721ac78a2b60c498a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 16, 2024
…tonly

Automatic update from web-platform-tests
webnn: implement reverse operator

This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <ningxin.huintel.com>
Auto-Submit: Shiyi Zou <shiyi.zouintel.com>
Reviewed-by: Austin Sullivan <asullychromium.org>
Reviewed-by: ningxin hu <ningxin.huintel.com>
Cr-Commit-Position: refs/heads/main{#1382078}

--

wpt-commits: 84f13be63d17cb4e6152782dc3fb4d49fb2842b5
wpt-pr: 49011

UltraBlame original commit: 60b2e3d5b43a1d85b6ef1d04b7b2e9d6a2cda530
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Nov 16, 2024
…r", a=testonly

Automatic update from web-platform-tests
Revert "webnn: implement reverse operator"

This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <ningxin.huintel.com>
> Auto-Submit: Shiyi Zou <shiyi.zouintel.com>
> Reviewed-by: Austin Sullivan <asullychromium.org>
> Reviewed-by: ningxin hu <ningxin.huintel.com>
> Cr-Commit-Position: refs/heads/main{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Reviewed-by: Yoichi Osato <yoichiochromium.org>
Owners-Override: Yoichi Osato <yoichiochromium.org>
Auto-Submit: Yoichi Osato <yoichiochromium.org>
Cr-Commit-Position: refs/heads/main{#1382142}

--

wpt-commits: 29bbccab8983b550c40cc394a398123a638d4223
wpt-pr: 49134

UltraBlame original commit: 107faff7e65875aa46d6e2b721ac78a2b60c498a
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 16, 2024
…tonly

Automatic update from web-platform-tests
webnn: implement reverse operator

This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <ningxin.huintel.com>
Auto-Submit: Shiyi Zou <shiyi.zouintel.com>
Reviewed-by: Austin Sullivan <asullychromium.org>
Reviewed-by: ningxin hu <ningxin.huintel.com>
Cr-Commit-Position: refs/heads/main{#1382078}

--

wpt-commits: 84f13be63d17cb4e6152782dc3fb4d49fb2842b5
wpt-pr: 49011

UltraBlame original commit: 60b2e3d5b43a1d85b6ef1d04b7b2e9d6a2cda530
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Nov 16, 2024
…r", a=testonly

Automatic update from web-platform-tests
Revert "webnn: implement reverse operator"

This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <ningxin.huintel.com>
> Auto-Submit: Shiyi Zou <shiyi.zouintel.com>
> Reviewed-by: Austin Sullivan <asullychromium.org>
> Reviewed-by: ningxin hu <ningxin.huintel.com>
> Cr-Commit-Position: refs/heads/main{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamperappspot.gserviceaccount.com>
Reviewed-by: Yoichi Osato <yoichiochromium.org>
Owners-Override: Yoichi Osato <yoichiochromium.org>
Auto-Submit: Yoichi Osato <yoichiochromium.org>
Cr-Commit-Position: refs/heads/main{#1382142}

--

wpt-commits: 29bbccab8983b550c40cc394a398123a638d4223
wpt-pr: 49134

UltraBlame original commit: 107faff7e65875aa46d6e2b721ac78a2b60c498a
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 18, 2024
This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf

The previous CL got reverted because another CL[1] changed the function
name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL
fixes the name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1384152}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Nov 18, 2024
This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf

The previous CL got reverted because another CL[1] changed the function
name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL
fixes the name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1384152}
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 18, 2024
…tonly

Automatic update from web-platform-tests
webnn: implement reverse operator

This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382078}

--

wpt-commits: 84f13be63d17cb4e6152782dc3fb4d49fb2842b5
wpt-pr: 49011
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Nov 18, 2024
…r", a=testonly

Automatic update from web-platform-tests
Revert "webnn: implement reverse operator"

This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Yoichi Osato <[email protected]>
Auto-Submit: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382142}

--

wpt-commits: 29bbccab8983b550c40cc394a398123a638d4223
wpt-pr: 49134
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 19, 2024
…r", a=testonly

Automatic update from web-platform-tests
Reland "webnn: implement reverse operator"

This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf

The previous CL got reverted because another CL[1] changed the function
name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL
fixes the name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try​:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1384152}

--

wpt-commits: 71926745e9dd263927f9f35229be2032d246205e
wpt-pr: 49207
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Nov 20, 2024
…tonly

Automatic update from web-platform-tests
webnn: implement reverse operator

This CL adds IDL and mojo definition of reverse operator according to
the spec issue [1] and implements it on DirectML backend.

[1] webmachinelearning/webnn#773

Bug: 376707210
Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
Commit-Queue: ningxin hu <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Reviewed-by: ningxin hu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382078}

--

wpt-commits: 84f13be63d17cb4e6152782dc3fb4d49fb2842b5
wpt-pr: 49011
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Nov 20, 2024
…r", a=testonly

Automatic update from web-platform-tests
Revert "webnn: implement reverse operator"

This reverts commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf.

Reason for revert: https://ci.chromium.org/ui/p/chromium/builders/ci/mac14-arm64-rel-tests/12103/test-results?sortby=&groupby=

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: Ie7ddada84b0e196d70da5cc42fab2c4ba2b0a13a
Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6013929
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Reviewed-by: Yoichi Osato <[email protected]>
Owners-Override: Yoichi Osato <[email protected]>
Auto-Submit: Yoichi Osato <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1382142}

--

wpt-commits: 29bbccab8983b550c40cc394a398123a638d4223
wpt-pr: 49134
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Nov 20, 2024
…r", a=testonly

Automatic update from web-platform-tests
Reland "webnn: implement reverse operator"

This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf

The previous CL got reverted because another CL[1] changed the function
name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL
fixes the name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try​:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1384152}

--

wpt-commits: 71926745e9dd263927f9f35229be2032d246205e
wpt-pr: 49207
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Nov 22, 2024
…r", a=testonly

Automatic update from web-platform-tests
Reland "webnn: implement reverse operator"

This is a reland of commit 0459ac1a9b94c1dd3e11410f7fb74f0a8e2ddeaf

The previous CL got reverted because another CL[1] changed the function
name `buildGraphAndCompute` to `buildAndExecuteGraph` in WPT. This CL
fixes the name.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/5556220

Original change's description:
> webnn: implement reverse operator
>
> This CL adds IDL and mojo definition of reverse operator according to
> the spec issue [1] and implements it on DirectML backend.
>
> [1] webmachinelearning/webnn#773
>
> Bug: 376707210
> Change-Id: I0d42b49b87ce243db9d44512e6000c7ee901077b
> Cq-Include-Trybots: luci.chromium.try​:win11-blink-rel, mac14.arm64-blink-rel, mac15.arm64-blink-rel, linux-blink-rel
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5979825
> Commit-Queue: ningxin hu <[email protected]>
> Auto-Submit: Shiyi Zou <[email protected]>
> Reviewed-by: Austin Sullivan <[email protected]>
> Reviewed-by: ningxin hu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1382078}

Bug: 376707210
Change-Id: I604de69bcc5f8932ac47f9f34a9b4c58e589193d
Cq-Include-Trybots: luci.chromium.try​:mac14.arm64-blink-rel, mac14-blink-rel, mac15.arm64-blink-rel, mac15-blink-rel, linux-blink-rel
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6015938
Reviewed-by: ningxin hu <[email protected]>
Commit-Queue: Shiyi Zou <[email protected]>
Auto-Submit: Shiyi Zou <[email protected]>
Reviewed-by: Weizhong Xia <[email protected]>
Reviewed-by: Alex Gough <[email protected]>
Reviewed-by: Austin Sullivan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1384152}

--

wpt-commits: 71926745e9dd263927f9f35229be2032d246205e
wpt-pr: 49207
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants