-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tensor type for the padding rather than MLOperand #224
Comments
As feedback of WebML WG Teleconference – 18 Nov 2021, the static attribute is preferred, e.g. @wchao1115 mentioned
Another reference is TensorFlow.js, according to tf.pad, the With that, I propose to change the @mingmingtasd , I am not sure whether it aligns with your proposal. What do you mean by using "tensor type"? |
Yes, that aligns with what I mean: using array. Thanks! @huningxin |
@mingmingtasd , as @wchao1115 's feedback, DirectML is supporting dynamic padding data. And NNAPI ANEURALNETWORKS_PAD_V2 also supports padding data as an operand. So it looks like the current pad op definition of WebNN is more future-proof. With that, I would withdraw my proposal and keep the current version. WDYT? |
Yes, I agree, thanks for your explaination. @huningxin |
Thanks for the feedback @mingmingtasd ! I'll close PR #233 and this one. |
The pad in the spec uses the
MLOperand padding
as its sencond input. But I find that the pad in DML and in IE, padding was defined with a tensor type. I think it's better to use tensor type to avoid the gap between spec and implementation.The text was updated successfully, but these errors were encountered: