Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved codebase #388

Open
1 of 12 tasks
magsout opened this issue May 8, 2021 · 0 comments
Open
1 of 12 tasks

improved codebase #388

magsout opened this issue May 8, 2021 · 0 comments
Assignees

Comments

@magsout
Copy link
Member

magsout commented May 8, 2021

I want to improved and made the codebase easier to maintain and understand. We use https://nextjs.org/ for the server and the client. So we can move local feature to nextjs features (like fetching data).

libraries

function components

Replaced class components by function components (by using react hook):

accessibility

added missing property like aria-*

fetching

Improved fetching by using getServerSideProps and swr

Then we could remove request

modules

renamed modules by normalizers then tests all functions.

@magsout magsout self-assigned this May 8, 2021
magsout added a commit that referenced this issue May 14, 2021
- removed lib
- added babel nullish-coalescing-operator and optional-chaining
@ksy36 ksy36 closed this as completed in 8613742 May 18, 2021
@magsout magsout reopened this May 18, 2021
@webcompat webcompat deleted a comment from jeremyandbandit Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant