New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ratio gives NaN result #33

Open

kalwalt opened this issue Jan 26, 2022 · 0 comments

Assignees

Labels

bug code-design

Member

kalwalt commented Jan 26, 2022 •

edited

Loading

The ratio setting https://github.com/webarkit/ARnft/blob/fd16f66908451c95174dacb4ee36c90c344304ff/examples/arNFT_example.html#L37 gives NaN. In some circumstances is very bad see for example this comment kalwalt/kalwalt-interactivity-AR#46 (comment) PR kalwalt/kalwalt-interactivity-AR#46 where the wrong setting and data may give unpredictable results. This should be fixed in all examples.

kalwalt added bug code-design labels

kalwalt self-assigned this

kalwalt mentioned this issue

Upgrading jsartoolkitnft webarkit/ARnft#260

Merged

5 tasks

kalwalt added a commit to webarkit/ARnft that referenced this issue


          fix for issue webarkit/ARnft-threejs#33

410a7ef

kalwalt added a commit to webarkit/ARnft that referenced this issue


          fix for issue webarkit/ARnft-threejs#33

d2cb77e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment