eslint fix #21
eslint fix #21
Conversation
|
@shubhamku044 is attempting to deploy a commit to the 100devs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
I think it's too many rules at the same time making it hard to review, even more with the JSON format (can't add inline comments, see first point below).
What I suggest:
- Adding an inline comment to
prettierin the config to remember that the config needs to be the last one in the list as recommended by their docs. This will require changing the.jsonformat to another one - Using directly
eslint: recommendedand incrementally change what we like or dislike about it.
| "prettier" | ||
| ], | ||
| "rules": { | ||
| "semi": "error", |
There was a problem hiding this comment.
This (and some other rules below) should be handled automatically by Prettier and overwritten by the prettier config.
There was a problem hiding this comment.
We are currently using npm for now (there is a package-lock.json in the repo).
Note that because our Workflow is using npm, this won't install the dependency because the package-lock.json was not in sync with package.json. With yarn it will sync yarn.lock with package.json but will left untouched the package-lock.json which is always used by npm ci command.
I don't mind switching the package manager, but this should be done in another Issue/PR and include an update for our workflow.
reviewpad
bot
added
the
git-conflict
reviewpad
bot
removed
large
I have fixed #18
#11