Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Optionally create .pxd files #69

Open
0dminnimda opened this issue Jul 3, 2022 · 3 comments · May be fixed by #70
Open

[Feature] Optionally create .pxd files #69

0dminnimda opened this issue Jul 3, 2022 · 3 comments · May be fixed by #70

Comments

@0dminnimda
Copy link
Contributor

If the creation of a parser using c was prohibited, because the original cpython pegen used too much internal functionality, then we can at least make python parser faster with cython.

Since pegen knows all the variables and types that users provide, it can use this information to create a .pxd file. This file will not interfere with pure python parser work, but it can be used by cython to create a faster compiled version of the parser.

I will implement this functionality anyway, but I wonder should I make it into PR and try to merge it here? Is this feature needed here?

@MatthieuDartiailh
Copy link
Collaborator

I would be interested in such a feature. And I could help review a PR.

@0dminnimda
Copy link
Contributor Author

Wonderful!

@0dminnimda
Copy link
Contributor Author

I forgot that right now cython does not support walrus operator, so for this change to be work at all we will probably need to merge this branch as well.

@0dminnimda 0dminnimda linked a pull request Jul 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants