Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The modal should not appear in desktop version, it should be when site is opened in tab or mobile mode. #16

Open
jainkeval opened this issue Mar 26, 2018 · 1 comment

Comments

@jainkeval
Copy link
Contributor

whatsapp image 2018-03-26 at 9 19 48 pm

@ajayns
Copy link
Collaborator

ajayns commented Mar 26, 2018

This is not an issue with UX.

The Sidebar Navigation drawer provides not only the basic navigation as in the main navbar, but also has groups and more links. For instance here, the 'Contact Us' contains direct links to social media sites. We can add more links/content as per requirements, excluding what's already there in the main navbar here.

I believe this is good design pattern, even thought not fully necessary. But we can always remove the button in desktop site if we want it mimic Bootstrap or so. @sumedh123 @kvnamipara Opinions?
This issue can be closed if we're fine with the current UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants