Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement config file #97

Open
Gigas002 opened this issue Mar 4, 2024 · 1 comment
Open

Implement config file #97

Gigas002 opened this issue Mar 4, 2024 · 1 comment

Comments

@Gigas002
Copy link

Gigas002 commented Mar 4, 2024

Hello everyone! Thank you for developing great screenshotting tool for Wayland desktops.

Since I personally prefer use configs instead of running apps with args, I came up with idea of implementing config file for wayshot. Sorry if you think that it doesn't fit for this project.
Here's an example with some properties I find essential for a screenshoting tool:

[keybindings]
screen = "ALT,PRTSCR"
selection = "PRTSCR"
window = "CTRL,PRTSCR"
cancel = "ESC"
save = "CTRL,C"

[screenshot]
# not sure what value should be here, since I've never used it
display = "default"
cursor = false

[screenshot.clipboard]
clipboard = true

[screenshot.filesystem]
filesystem = true
path = "~/images/screenshots"
format = "%Y-%m-%d_%H:%M:%S"
extension = "webp"

Looked into wayshot/src/clap.rs for some properties to include here too.
I may be guessing something incorrectly, since I'm not aware which of these are in scope of the project (e.g. probably the keybindings should be handled on a compositor-level config..?)

AFAIK there's no reads from keyboard in program, since it uses slurp for selection, so I don't think the keybindings are in the scope of the project, not at until #1 is closed, at least.
Except for this, I think that path is in progress in #96?
And from the looks of it, it doesn't seem hard to implement custom format specification.

@Shinyzenith
Copy link
Member

Hello everyone! Thank you for developing great screenshotting tool for Wayland desktops.

❤️

Since I personally prefer use configs instead of running apps with args, I came up with idea of implementing config file for wayshot. Sorry if you think that it doesn't fit for this project. Here's an example with some properties I find essential for a screenshoting tool:

While I'd like to not expand the projejct into config sections, I'm not too against it either -- I think we should maybe have the other maintainers drop in their ideas too. CC: @Decodetalkers (feel free to ACK the proposal).

Looked into wayshot/src/clap.rs for some properties to include here too. I may be guessing something incorrectly, since I'm not aware which of these are in scope of the project (e.g. probably the keybindings should be handled on a compositor-level config..?)

Keybindings are compositor policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants