-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support instantly taking screenshot before choosing portion with slurp #62
Comments
I don't quite understand what this sentence means.
Please correct me if I understood you incorrectly:
Proposed solution:Here's a solution that I had thought of since day 1 of writing wayshot which might be more feasible. We take a full-monitor screenshot of the active monitor and then just pipe the contents into a second program ( a swappy clone which is fast and not laggy.. ), here we can do: cropping/blurring/coloring etc etc I never got the time to execute this idea but if someone wants to pick up on it, let me know. |
When we pass So currently it's "slurp -> region screenshot". We would need "screenshot everything -> slurp -> crop".
We don't necessarily need to encode them in the middle. We can keep the buffer in memory and drop/destroy it when we no longer need it. This also will not lead to any loss in quality, we are however holding onto more memory and for slightly longer. Though I don't think this is an issue.
I'm not sure if you're asking me anything here. Though we will indeed take an entire screenshot each time.
Yes, Would you be down to chat on Discord and we can possibly talk further there? I'll post something. |
add thread sleep to delay screenshot, make it can shot some dialog Issue: waycrate#62
Future reference: we discussed further via Discord. Will share a PoC when ready. |
I often want to take a screenshot from a popup window, whether it be in the browser or elsewhere. Unfortunately these popups close when focus is lost. MacOS takes a screenshot when the screenshot button is pressed and the selection tool then allows you to select a portion of the screen thus allowing you to take screenshot of popups.
Having this functionality in Wayshot would not be trivial as it would require creating an overlay on which slurp can then be used. Currently
slurp
is also run before Wayshot so we cannot take a screenshot and show it as a moment capture before running slurp so that needs to be changed as well. We could make--slurp
accept any command and run it from inside of the CLI so we can take a screenshot first and show it to the user after which we can run slurp to select what thay want and then we'd only need to do a crop. What do you think?The text was updated successfully, but these errors were encountered: