Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Cargo test failing #113

Open
id3v1669 opened this issue Apr 6, 2024 · 2 comments
Open

Error: Cargo test failing #113

id3v1669 opened this issue Apr 6, 2024 · 2 comments

Comments

@id3v1669
Copy link

id3v1669 commented Apr 6, 2024

After this commit cargo test is failing. Even though it is not used in Makefile, cargo test is used by default for rust packages in nix.
So the question is: Will there be a fix for that, or should tests just be ignored?

@id3v1669
Copy link
Author

id3v1669 commented Apr 6, 2024

Probably could be fixed by replacing:

/// Struct to store wayland connection and globals list.
/// # Example usage
///
/// ```
/// let wayshot_connection = WayshotConnection::new().unwrap();
/// let image_buffer = wayshot_connection.screenshot_all().unwrap();
/// ```

with:

/// Struct to store wayland connection and globals list.
/// # Example usage
///
/// ```ignore
/// use libwayshot::WayshotConnection;
/// 
/// let wayshot_connection = WayshotConnection::new().unwrap();
/// let image_buffer = wayshot_connection.screenshot_all().unwrap();
/// ```

changes:

  • use libwayshot::WayshotConnection; was added to avoid errors with cargo test
  • ignore was used to avoid errors within nix build

Notes

With ignore first change is not necessary, but still nice to have.

@Decodetalkers
Copy link
Collaborator

Ohh , this is missed, please send a pr to us, thanks, I will approve it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants