feat(clipboard): fix interaction with freeze and select feature: Issue #109 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Andreas is fairly busy this week, do not expect a fast response. |
AndreasBackx
suggested changes
Apr 1, 2024
libwayshot/src/lib.rs
Outdated
| &self, | ||
| frames: &[(FrameCopy, FrameGuard, OutputInfo)], | ||
| callback: Box<dyn Fn() -> Result<LogicalRegion, Error>>, | ||
| ) -> Result<(LogicalRegion)> { |
There was a problem hiding this comment.
Suggested change
| ) -> Result<(LogicalRegion)> { | |
| ) -> Result<LogicalRegion> { |
@Shinyzenith it seems like we don't have clippy enabled in GitHub actions?
Compiling wayshot v1.3.2-dev (/home/andreas/dev/wayshot/wayshot)
warning: unused import: `Region`
--> libwayshot/src/lib.rs:55:29
|
55 | region::{LogicalRegion, Region, Size},
| ^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: unnecessary parentheses around type
--> libwayshot/src/lib.rs:422:17
|
422 | ) -> Result<(LogicalRegion)> {
| ^ ^
|
= note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
|
422 - ) -> Result<(LogicalRegion)> {
422 + ) -> Result<LogicalRegion> {
|
warning: unused import: `GenericImageView`
--> libwayshot/src/image_util.rs:1:27
|
1 | use image::{DynamicImage, GenericImageView};
| ^^^^^^^^^^^^^^^^
warning: unused variable: `logical_height`
--> libwayshot/src/image_util.rs:15:25
|
15 | let (logical_width, logical_height) = match transform {
| ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_logical_height`
|
= note: `#[warn(unused_variables)]` on by default
warning: `libwayshot` (lib) generated 4 warnings (run `cargo fix --lib -p libwayshot` to apply 3 suggestions)
warning: unused import: `fs::File`
--> wayshot/src/wayshot.rs:2:5
|
2 | fs::File,
| ^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
warning: `wayshot` (bin "wayshot") generated 1 warning (run `cargo fix --bin "wayshot"` to apply 1 suggestion)
Finished release [optimized] target(s) in 0.92s
Running `target/release/wayshot --clipboard --slurp ''`
Error: error occurred in freeze callback
Location:
wayshot/src/wayshot.rs:72:9
Shouldn't impact the PR, but wanted to mention.
This was referenced Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies the overlay creation function to destroy the shell surfaces after use. Not much familiar with layer shell so input from @AndreasBackx would be appreciated on if this is all that is required. I have moved the slurp callback activation into that function too because it needs to be called before the surface is destroyed and destroying the surface needs context only present within this function.