-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brightness keys are not detected #71
Comments
for this to work we need to read events on video outputs...I don't know how to do that right now. |
it works fine for me.
^Triggers as expected when pressing the brightness adjustment keys on my laptop. |
what compositor are you on? |
I tried it on bspwm and river. Both the audio keys and the brightness keys work... In testing I found there is a mistake for the |
On my device the brightness controls are emitted by the video outputs..might be hardware specific. |
Hi, @loiccoyle @Shinyzenith Would you mind testing again on the latest version to check if this is still an issue for you? |
Sure thing! I'll try as soon as I get access to my laptop but the last time I checked with libinput debug logs, on some machines (such as my laptop) they are emitted by video devices. |
@ajanon Yep! this issue still occurs. |
The events are emitted by |
What happens if you forcibly grab the device with |
Upon grabbing forcibly with |
Should we drop the keyboard device detection now? Maybe it is not necessary anymore and we can just grab all devices. |
To be completely fair, the keyboard device detection has been extremely flawed to begin with! I think I agree with you, we should drop the check all-together and just parse the events we care about and re-emit the rest all through uinput. Should we create an issue to track this? Note: Reminder to add to README/FAQ that all device configurations should henceforth be made to the uinput device instead of the specific devices due to swhkd's grab. |
I created issue #191 about this. @Shinyzenith Feel free to add your reminder there! |
How do you grab the device with --device ? i am not understanding the concept |
swhkd cannot at least for now manage these keys, see this issue: waycrate/swhkd#71
As a workaround, one can bind these to the proper commands using a Wayland compositor. |
Expected behavior:
Brightness keys are detected and respond to keybinds.
Actual behavior:
Brightness keys are not detected.
To Reproduce:
set keybinds with xf86brightnessup
The text was updated successfully, but these errors were encountered: