Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waves startup issue when there is a wallet issue. #3362

Open
Crypto2 opened this issue Feb 8, 2021 · 3 comments
Open

Waves startup issue when there is a wallet issue. #3362

Crypto2 opened this issue Feb 8, 2021 · 3 comments
Assignees
Labels

Comments

@Crypto2
Copy link

Crypto2 commented Feb 8, 2021

I've noticed 2x over the years that Waves has a dangerous issue when it starts up if there is an issue loading the wallet. Instead of printing an error and refusing to run it just silently creates a new wallet with a new seed (even if the wallet seed is specified in the config file). It actually doesn't mention there was an issue at all and acts like nothing happened.

@Crypto2
Copy link
Author

Crypto2 commented May 15, 2021

Any update on this? It seems to do it randomly even if it was shut down properly let alone if there was any error or crash or anything.

@DrBlast
Copy link
Member

DrBlast commented May 17, 2021

  1. If wallet file is corrapted, then node will not start.
  2. If you change seed and not delete wallet-file, node will start with old seed. Wallet seed has a priority to config-seed. It's not a bug, but we will change tis option in future releases
  3. If you delete wallet file, node will create new instead of deleted.

Or you have another issue?

@Crypto2
Copy link
Author

Crypto2 commented May 19, 2021

  1. This would be the expected behavior but in these cases I'm seeing it will start without printing any errors and with a new seed. It mainly happens if there is a crash while the node is running but it does it just randomly on startup as well.
  2. This would be the expected behavior but I haven't tested it so I can't comment on it.
  3. This is correct from my experience, every time I've seen it make a wallet from scratch it used the seed in the config file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants