Begin localization efforts #12
Conversation
I may or may not have found the wrong library on Google. Will discuss this in the PR.
✅ Deploy Preview for melodic-snickerdoodle-1f6e46 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@CenTdemeern1 I think the sveltekit-i18n/lib library is ok, I do prefer that it has fewer dependencies. And this will also save time on reworking more stuff. In this PR let's just finish the core setup for at minimum |
Co-Authored-By: Vladyslav Tatarin <[email protected]>
Got stuck in debugging for a bit, misread an error Co-Authored-By: Vladyslav Tatarin <[email protected]>
Since I'm going to experiment with markdown stuff I'm going to use this commit as a restore point I can come back to in case I screw something up
Added a link to Daniru's Twitter as well.
Dedupes a bunch of code. I didn't want this to begin with, but I just didn't know how to do it. Skill issue on my end, apologies.
How did this happen
|
Hey @DaniruKun apparently marked (the markdown package we're using) requires Node 18 or up, should CI be updated? (or can we only use 16 for some reason) Show logs |
|
Should be possible to set 18 in Netlify, I'll let you know when it's ready. |
|
@CenTdemeern1 updated Netlify builder node version to latest |
|
Alrighty let's try a rerun |
|
I'll commit... uh... something |
|
"this branch has not been deployed" ????? |
|
Deploy should now be live at https://main--melodic-snickerdoodle-1f6e46.netlify.app |
|
Looks like it works, thanks! |
|
@CenTdemeern1 what's the current status of the PR btw? Just want to know somewhere during the week so I know if I should create a new branch off of it, or we merge it into the trunk, since I want to work on the redesign a bit. |
|
I'll continue working on this when I'm done with GMTK, this branch should be able to be merged soon |
|
@CenTdemeern1 do you need some support in this branch atm? |
|
@DaniruKun since Haato's diary is finished now I can get back to doing this, so help is not needed but if you want to help sure |
THIS IS A DRAFT.
It should not be merged (or marked as ready for review) in its current state.
I may or may not have found the wrong library on Google1 (so not the one that was referred to in #102). Is this library fine, or should I switch what library is used?According to the docs of the library mentioned in #10, its SvelteKit solution is inspired by the library I'm using here.3
Footnotes
Update: nope, I completely blame @DaniruKun
↩
The library being referred to here is https://github.com/kaisermann/svelte-i18n. For reference, the library being used right now is https://github.com/sveltekit-i18n/lib. ↩
See https://github.com/kaisermann/svelte-i18n/blob/main/docs/Svelte-Kit.md#usage-in-svelte-kit ↩