-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo support (reopen of #53) #54
base: master
Are you sure you want to change the base?
Conversation
This is really neat. Could you tag a release with an APK in your fork? |
I might just publish on the playstore, although I'd rather have it accepted On Mon, May 11, 2015, 22:10 Shreyas [email protected] wrote:
|
I mean it might get rejected as it really breaks the roguelike aspects of the game... Regardless, it'd be cool if you had a release on your fork. I'd love to play and contribute to this. |
Watabou does not accept or even really aknowledge pull requests, and this violates the roguelike nature of the game, so the chance of this getting merged is basically 0. It's a neat idea though. |
The patched version is available on the android play-store: Let me know what you think |
Will definitely take a look tonight. Looks pretty sweet. How far back does it go? |
It goes back 10 turns On Tue, Jul 14, 2015, 16:26 Shreyas [email protected] wrote:
|
What I meant is can you undo multiple times? |
I just keep a list of the last 10 steps,, and undo will go to the oldest On Tue, Jul 14, 2015, 18:11 Shreyas [email protected] wrote:
|
# Conflicts: # src/com/watabou/pixeldungeon/Dungeon.java # src/com/watabou/pixeldungeon/scenes/InterlevelScene.java
re-opening of pull request #53 which was inadvenrtantly deleted by me. I just wanted to rename my branch ....
Original test from #53:
After some frustrating silly deaths I decided to add an undo function. I takes you back 10 steps, and will also work when you're dead.
I know there is a small chance of it being acepted with it being against the whole roguelike idea, but just in case, I tried to make it as easy as posible to merge.
It works by saving the game/level on hero.idle() to a size 10 FIFO buffer which is written to using a ByteArrayStream.
When requesting undo the game & level are reaf back from the first (oldest) FIFO elemet.
Shai