Neater Code :) #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not know this guy. (Swears) |
|
just want to help people out :) whenever i can |
|
Neater is always better, but the way I see it the majority of these comments are unneeded. They're just repeating the function name. |
|
I agree. I am mostly talking about the spacing. |
| duration = 0; | ||
|
|
||
| qualifiedForNoKilling = false; | ||
|
|
||
| //Set amuletObtained to false | ||
| amuletObtained = false; |
There was a problem hiding this comment.
//Say "Ok, now I'm sure you are trolling"
There was a problem hiding this comment.
Guys, the comments are sure not needed, var names are good enough to understand whats going on.
|
Sorry, That was silly of me to put :) |
ghost
closed this
ghost
reopened this
VNystad
suggested changes
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.