Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Condition in Cipher Mode Check #525

Open
XiaoLey opened this issue May 12, 2024 · 1 comment
Open

Redundant Condition in Cipher Mode Check #525

XiaoLey opened this issue May 12, 2024 · 1 comment
Labels

Comments

@XiaoLey
Copy link

XiaoLey commented May 12, 2024

Description

It has been observed that there are two lines of code where the condition check for the cipher mode appears to be redundant. Specifically, both instances check for the same condition twice within a single statement.

image

Code Location

The redundant condition appears in two different locations:

Link to code location 1

Link to code location 2

Possible Typo?

It might be a typo that the second condition was intended to check another cipher mode, potentially cipher_aes128cfb. It's worth verifying whether this was the intended logic.

Suggested Action

It would be advisable to review these conditions and correct them if one of them should indeed be cipher_aes128cfb, or if another cipher mode was intended to be checked.

@wangyu- wangyu- added the bug label May 13, 2024
@wangyu-
Copy link
Owner

wangyu- commented May 13, 2024

Hi this is a bug, if --fix-gro is enabled for cipher_aes128cfb the 16bit gro header is by mistake left unencrpyted.

I will make a fix, hopefully next weekend.

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants