Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessarily passing cleartext URLs of all pages visited to server #204

Open
00dani opened this issue Mar 19, 2020 · 4 comments
Open

Unnecessarily passing cleartext URLs of all pages visited to server #204

00dani opened this issue Mar 19, 2020 · 4 comments

Comments

@00dani
Copy link
Contributor

00dani commented Mar 19, 2020

The "Indicate if page already saved" option is expected to make requests to your Wallabag server for every URL you visit, so it can check whether that URL is already saved. However, it currently uses the url query parameter to pass these URLs up as cleartext, and it doesn't need to.

The /api/entries/exists endpoint can instead be passed a hashed_url parameter, which is the SHA-1 hash of a URL and can also indicate whether a URL matching that hash exists on the server. Wallabagger should use this parameter instead, to avoid potentially leaking every URL you ever visit.

I don't know which versions of Wallabag support the hashed_url parameter, so it may be necessary to maintain support for cleartext checks as well. But making hashed_url available as an alternative option is certainly viable.

@Simounet
Copy link
Member

Simounet commented Nov 7, 2020

This would be a great feature but I'm not sure if there is a tagged wallabag's version out there right now. Could you confirm this info @nicosomb or @j0k3r, please?

@j0k3r
Copy link
Member

j0k3r commented Nov 7, 2020

Not yet.
I would like to release the 2.4.0 this month.

@Simounet
Copy link
Member

Simounet commented Nov 7, 2020

Ok perfect. Will the generate-hashed-urls processing integrated to the update or manually launched by admins (just to be sure if I can count on this field after this precise version)?

@Simounet Simounet pinned this issue Nov 7, 2020
@j0k3r
Copy link
Member

j0k3r commented Nov 7, 2020

It'll be listed in the how to upgrade, see wallabag/wallabag#4361 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants