chore!: update proto definitions #1196
Conversation
fryorcraken
force-pushed
the
chore/update-proto-definition
branch
from
2b66cba to
affd3d6
Compare
size-limit report 📦
|
fryorcraken
changed the title
fryorcraken
force-pushed
the
chore/update-proto-definition
branch
from
abe44a7 to
2710889
Compare
| @@ -408,7 +404,7 @@ export async function createCursor( | |||
| digest, | |||
| pubsubTopic, | |||
| senderTime: messageTime, | |||
| receivedTime: messageTime, | |||
| receiverTime: messageTime, | |||
There was a problem hiding this comment.
I am surprised that using the waku message timestamp here works. Cc @LNSD @danisharora099
|
@fryorcraken. would it make sense to instead of including the .proto files in the project, to use a git submodule pointing to vacp2p/waku? |
| @@ -8,16 +8,16 @@ export type ContentFilter = { | |||
| /** | |||
| * FilterRPC represents a message conforming to the Waku Filter protocol | |||
| */ | |||
| export class FilterRPC { | |||
| public constructor(public proto: proto.FilterRPC) {} | |||
| export class FilterRpc { | |||
There was a problem hiding this comment.
Why did you change capitalisation here?
There was a problem hiding this comment.
Capitalization was changed on proto file to proper PascalCase, I just match it as PascalCase is what we use across the codebase.
Maybe. There is an issue with the peer exchange definition (I need to create an issue) hence we cannot use the repo as is just yet. The other question is whether Let's review once peer exchange is done. |
The issue: waku-org/waku-proto#14 |
fryorcraken
force-pushed
the
chore/update-proto-definition
branch
from
357f9ca to
81d6638
Compare
Use protobuf definitions from https://github.com/vacp2p/waku
Ref: #335